Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AdaBoost model and option to train on a subset of features #218

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Add AdaBoost model and option to train on a subset of features #218

merged 3 commits into from
Jan 29, 2024

Conversation

luccalb
Copy link
Collaborator

@luccalb luccalb commented Jan 26, 2024 •
edited
Loading

Added the following:

  • AdaBoost Classifier (DecisionTree under the hood)
  • Option to select a subset of features for training in EVP demo
  • Add results to documentation

@luccalb
Add AdaBoost model and option to train on a subset of features
47a28f4 
Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
@luccalb luccalb self-assigned this Jan 26, 2024
ultiwinter
ultiwinter reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@ultiwinter ultiwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run it yet, but looks good. You could as well add in the documentation its performance.

@luccalb
Added experiment results and marked the best performing classifier pe…
d97d90f 
…r class

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
@luccalb
Copy link
Collaborator Author

luccalb commented Jan 26, 2024

I didn't run it yet, but looks good. You could as well add in the documentation its performance.

Just added the docs :)

@luccalb
Minor changes to docs
076f688 
Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
ultiwinter
ultiwinter approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@ultiwinter ultiwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Just a comment/question.

@ultiwinter ultiwinter mentioned this pull request Jan 28, 2024
Merged
@ultiwinter ultiwinter linked an issue Jan 28, 2024 that may be closed by this pull request
Final iteration of ML model #216
Closed
@luccalb luccalb merged commit 008d5e6 into dev Jan 29, 2024
4 checks passed
@luccalb luccalb deleted the feature/adaboost-with-feature-subset branch January 29, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultiwinter ultiwinter ultiwinter approved these changes

@rbbozkurt rbbozkurt Awaiting requested review from rbbozkurt

@ur-tech ur-tech Awaiting requested review from ur-tech

Assignees

@luccalb luccalb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Final iteration of ML model
2 participants
@luccalb @ultiwinter