-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to vega datasets v2 #40
Open
eitanlees
wants to merge
16
commits into
altair-viz:master
Choose a base branch
from
eitanlees:update-to-vega-datasets-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update to vega datasets v2 #40
eitanlees
wants to merge
16
commits into
altair-viz:master
from
eitanlees:update-to-vega-datasets-v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2020
Open
eitanlees
force-pushed
the
update-to-vega-datasets-v2
branch
from
September 20, 2020 17:31
ad5334d
to
c924df9
Compare
I will work on fixing up this PR and let you know when it's ready again to be merged. |
Alright, all tests are passing and I think everything is good to go! @jakevdp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big update! I think I covered all of my bases.
football.json
.penguins.json
.seattle-weather-hourly-normals.csv
.weather.csv
andseattle-weather.csv
with better encoded weather condition, indicating more rain. Thanks to @visnup!seattle-weather.csv
.weball26.json
topolitical-contributions.json
.birdstrikes.json
tobirdstrikes.csv
and use ISO 8601 dates.movies.json
to use column names with spaces use ISO 8601 dates.climate.json
.seattle-temps.csv
with more generalseattle-weather-hourly-normals.csv
.sf-temps.csv
.graticule.json
. Use graticule generator instead.points.json
.iris.json
. Usepenguins.json
instead.I think this will call for a major version bump as well, but I don't know much about how python packaging works 😛