Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to v2 #39

Open
eitanlees opened this issue Jun 19, 2020 · 6 comments
Open

Transition to v2 #39

eitanlees opened this issue Jun 19, 2020 · 6 comments

Comments

@eitanlees
Copy link
Contributor

The vega/vega-datasets repository recently released a major update. A few changes will need to be made to catch up. I just wanted to file this issue to get the ball rolling.

I can work on it and submit a PR when I get a bit of free time :)

@eitanlees
Copy link
Contributor Author

Hey, I wanted to check back in about getting altair/vega_datasets up to date with vega/vega-datasets.

The merge of #42 seems to have caused a failing build, but I am unsure why? (It might just be a fluke?)

The current release on PyPI is version 0.8.

I am unsure if you want to release a version 0.9 with the addition of the CDN base url, and then later release a version 1.0 which would introduce some breaking changes.

PR #40 is the big one which would bring everything up to date. Currently there are a few merge conflicts which I can resolve once we have a plan.

I think @jakevdp is the only one who can do the PyPI release.

@domoritz
Copy link

domoritz commented Sep 20, 2020

It would be great to get this update in so that the examples on the Altair website work again (#43).

@eitanlees
Copy link
Contributor Author

I will work on the #40 and let you know when it's good to go

@eitanlees
Copy link
Contributor Author

Alright, I revisited #40, rebased on mater, and cleaned things up. All tests are passing and I think everything should be good to go.

@domoritz
Copy link

Did you want to make a release for Vega datasets 1 with versioned CDN links (I can't check right now so excuse me if you've already done it).

@eitanlees
Copy link
Contributor Author

We haven't done that yet. I think @jakevdp is the only one who can do a PyPI release, so that is up to him.

Seems like a good idea though. v0.9 would introduce the CDN links, and v1.0 would introduce breaking changes that would bring the packaged up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants