Exclude Details elements from HTML sanitization for inline attachments #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardkerry
force-pushed
the
detailed-guide-acc-req-show-hide
branch
4 times, most recently
from
6b85de3 to
784c9d2
Compare
edwardkerry
changed the title
edwardkerry
force-pushed
the
detailed-guide-acc-req-show-hide
branch
2 times, most recently
from
1ee6db8 to
5852de6
Compare
Inline attachments are wrapped in a `<details>` HTML element which is being sanitized and removed by Govspeak. This is preventing a JS module from attaching and results in the accessible format request block always being expanded. This change allows editions with inline attachments to request that Govspeak excludes the `details` element from sanitization by submitting it as a string in the optional `allowed_elements` array
edwardkerry
force-pushed
the
detailed-guide-acc-req-show-hide
branch
from
5852de6 to
e930480
Compare
thomasleese
approved these changes
Jan 15, 2021
ChrisBAshton
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline attachments are wrapped in a
<details>HTML element which isbeing sanitized and removed by Govspeak. This is preventing a JS module
from attaching and results in the accessible format request block
always being expanded.
This change allows editions with inline attachments to request
that Govspeak excludes the
detailselement from sanitizationby submitting it as a member of the optional
allowed_elementsarray.This was introduced to Govspeak in release 6.6.0
trello