Allow optional elements to skip sanitisation #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardkerry
force-pushed
the
allow_optional_elements_to_skip_sanitisation
branch
from
e9bf230 to
5e514e4
Compare
kevindew
reviewed
Jan 13, 2021
| test "it can exclude stipulated elements from sanitization" do | ||
| document = Govspeak::Document.new("<uncommon-element>some content</uncommon-element>", relaxed_sanitization_elements: %w[uncommon-element]) | ||
| assert_equal "<uncommon-element>some content</uncommon-element>", document.to_html.strip | ||
| end |
edwardkerry
force-pushed
the
allow_optional_elements_to_skip_sanitisation
branch
from
5e514e4 to
7b497c0
Compare
This change allows an optional array of `allowed_elements` to be passed to a new Document, and these will be excluded from HTML sanitization.
edwardkerry
force-pushed
the
allow_optional_elements_to_skip_sanitisation
branch
from
7b497c0 to
03e9d88
Compare
thomasleese
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows an optional array of
relaxed_sanitization_elementsto be passed to a new Document, and these will be excluded from HTML sanitization.There is a use-case where Whitehall is submitting a
<details>element which is being stripped by sanitization.Trello