Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING Use component wrapper on print link component #4576

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 21, 2025

What

  • Adds the component wrapper to the print link component
  • This is a breaking change, as it renames the data_attributes object that was used on child elements. This is not actually used across any templates currently, so it can be safely removed.
  • Although this is a breaking change, it shouldn't affect any existing code on GOVUK.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

Edited example titles/descriptions.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4576 January 21, 2025 09:59 Inactive
@AshGDS AshGDS force-pushed the print-link-component-wrapper branch from d2e4cce to 5dec713 Compare January 21, 2025 09:59
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4576 January 21, 2025 09:59 Inactive
@AshGDS AshGDS force-pushed the print-link-component-wrapper branch from 5dec713 to c92b624 Compare January 21, 2025 10:35
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4576 January 21, 2025 10:35 Inactive
@AshGDS AshGDS changed the title Use component wrapper on print link component BREAKING Use component wrapper on print link component Jan 21, 2025
@AshGDS AshGDS self-assigned this Jan 21, 2025
@AshGDS AshGDS force-pushed the print-link-component-wrapper branch from c92b624 to 94b9553 Compare January 21, 2025 10:42
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4576 January 21, 2025 10:42 Inactive
@AshGDS AshGDS marked this pull request as ready for review January 21, 2025 10:46
@AshGDS AshGDS requested a review from andysellick January 21, 2025 10:46
@AshGDS AshGDS merged commit 624c88a into main Jan 21, 2025
12 checks passed
@AshGDS AshGDS deleted the print-link-component-wrapper branch January 21, 2025 12:01
unoduetre added a commit that referenced this pull request Jan 22, 2025
* Remove margin top from search component ([PR #4581](#4581))
* **BREAKING** Add component wrapper helper to textarea ([PR #4574](#4574))
* Remove margin top from print link ([PR #4577](#4577))
* **BREAKING** Use component wrapper on print link component  ([PR #4576](#4576))
* Refactor single page notification component ([PR #4501](#4501))
* Remove shared helper from button component ([PR #4569](#4569))
* Remove shared helper from inset text component ([PR #4571](#4571))
* Use component wrapper on contextual footer ([PR #4562](#4562))
* Update Govspeak "Warning Text" component styles ([PR #4487](#4487))
* Make "Add another" component styles more specific ([PR #4579](#4579))
* Translate "and" connective in metadata component to Chinese, Russian and Arabic ([PR #4580](#4580))
@unoduetre unoduetre mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants