Remove shared helper from inset text component #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
inset-text-sh-remove
branch
from
07a22ea to
fe15bec
Compare
andysellick
force-pushed
the
inset-text-sh-remove
branch
from
fe15bec to
ad10dc1
Compare
AshGDS
approved these changes
Jan 20, 2025
unoduetre
added a commit
that referenced
this pull request
Jan 22, 2025
* Remove margin top from search component ([PR #4581](#4581)) * **BREAKING** Add component wrapper helper to textarea ([PR #4574](#4574)) * Remove margin top from print link ([PR #4577](#4577)) * **BREAKING** Use component wrapper on print link component ([PR #4576](#4576)) * Refactor single page notification component ([PR #4501](#4501)) * Remove shared helper from button component ([PR #4569](#4569)) * Remove shared helper from inset text component ([PR #4571](#4571)) * Use component wrapper on contextual footer ([PR #4562](#4562)) * Update Govspeak "Warning Text" component styles ([PR #4487](#4487)) * Make "Add another" component styles more specific ([PR #4579](#4579)) * Translate "and" connective in metadata component to Chinese, Russian and Arabic ([PR #4580](#4580))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the shared helper from the inset text component. Specifically, this removes the
margin_topoption from the component.I've checked the 14 applications this component is used in and as far as I can tell none of them were using the
margin_topoption, so this seems safe to remove.Why
We're trying to move some options out of the shared helper and into the component wrapper helper, as well as doing some cleanup, specifically to standardise our components to only use margin bottom. Removing this option from this component gets us one step closer to that goal.
Visual Changes
Inset text had a default top margin of Design System spacing 6 applied through the shared helper but also has the same top margin from the Design System component styles, so removing this makes no visual difference.
Trello card: https://trello.com/c/Y0pDWbHw/390-move-some-shared-helper-options-into-component-wrapper