Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA4 modules error checking #3228

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

andysellick
Copy link
Contributor

What

Wraps the initialisation of each GA4 analytics module in a try/catch block, which means that any errors in the initialisation of a module will not prevent any following modules from initialising.

Why

Follows on from this similar change to the main modules systems, which prevents an individual module failing from stopping all following modules from initialising.

Visual Changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3228 February 2, 2023 12:10 Inactive
@andysellick andysellick force-pushed the add-analytics-modules-error-check branch from 9c190ac to 0d8ac0f Compare February 2, 2023 12:11
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3228 February 2, 2023 12:11 Inactive
@andysellick andysellick marked this pull request as ready for review February 2, 2023 12:11
@andysellick andysellick force-pushed the add-analytics-modules-error-check branch from 0d8ac0f to 5ba385e Compare February 2, 2023 13:16
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3228 February 2, 2023 13:17 Inactive
@andysellick andysellick merged commit 32787e8 into main Feb 2, 2023
@andysellick andysellick deleted the add-analytics-modules-error-check branch February 2, 2023 14:34
@jon-kirwan jon-kirwan mentioned this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants