Catch errors when modules initialised #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
catch-module-errors
branch
from
8fe38a7 to
258d9cc
Compare
andysellick
force-pushed
the
catch-module-errors
branch
from
258d9cc to
a24a7fc
Compare
AshGDS
approved these changes
Jan 17, 2023
andysellick
force-pushed
the
catch-module-errors
branch
from
a24a7fc to
94932f0
Compare
- wraps the initialisation of modules on a page with a try/catch block, so that if an error occurs in one module initialisation continues to the next without aborting and breaking all of the JS that follows
andysellick
force-pushed
the
catch-module-errors
branch
from
94932f0 to
5e3a46a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
We've had some recent problems where an error in a single bit of JS caused all of the following JS to also fail.
Visual Changes
None.
All credit goes to @AshGDS for thinking of this idea.