Inconsistent spacing on conditional element in example #345
Assignees
Comments
6 tasks
philsherry
pushed a commit
to philsherry/govuk_elements
that referenced
this issue
Dec 29, 2016
This release includes two breaking changes: - Removal of external link styles and icons, if you are using the external-link-* mixins you will need to remove them from your codebase ([PR alphagov#293](alphagov/govuk_frontend_toolkit#293)) - Correct spelling of the 'accordion' icon, you will need to check for the incorrect spelling 'accordian' and update if you are using this icon ([PR alphagov#345](alphagov/govuk_frontend_toolkit#345)) And two minor changes: - Amend GOVUK.StickAtTopWhenScrolling to resize the sticky element and shim when the .js-sticky-resize class is set ([PR alphagov#343](alphagov/govuk_frontend_toolkit#343)) - Allow custom options in GOVUK.analytics.trackPageview ([alphagov#332](alphagov/govuk_frontend_toolkit#332))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One of the examples includes a yes/no inline question, with conditional fields revealed once an answer is given.
The spacing on one of the conditional fields is wrong.
Video:
How would you expect it to work?
The correct spacing is on the 'no' answer - the yes answer has too little spacing.
How does it work currently?
The spacing is inconsistent.
Feel free to suggest a fix...
It looks like the second option is correctly spaced because it has a margin-top of 10px. However this margin top is applied only to the last child - in this case there are two children so the first hidden question does not get the margin.
Explain the steps to reproduce the bug
Visit govuk-elements example page and try the yes / no inline example.
The text was updated successfully, but these errors were encountered: