-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skiplink moves focus to before the phase banner #343
Comments
Yeah, I don’t agree that breadcrumbs should be outside |
To me it makes sense for it to be outside of main, or at the very least for the skip link to go directly to the content and not to any breadcrumbs. I wonder what @aduggin thinks. |
I agree with Ed and Tom - skip links should take you directly to the main content. It recommends this here: https://www.w3.org/TR/WCAG20-TECHS/G1.html and "Example 2: A "Skip to main content" link |
The removal of the phase banner from GOV.UK elements has fixed part of this issue, however, the breadcrumb links sit within the A solution to this would be to add a parent wrapper div to constrain the main content area using the frontend toolkit's site-width-container placeholder and to move the breadcrumb out of It would also be useful to add this information about where we expect the phase banner and breadcrumb to be to the govuk_template docs - as this is where we already have guidance for setting a skiplink to #content. |
I agree that the skip link should go to the main content and breadcrumbs should be outside that. Some sites have more than one skip link, but if we don't want to go down that route "skip to main content" should bypass all navigation. |
This release includes two breaking changes: - Removal of external link styles and icons, if you are using the external-link-* mixins you will need to remove them from your codebase ([PR alphagov#293](alphagov/govuk_frontend_toolkit#293)) - Correct spelling of the 'accordion' icon, you will need to check for the incorrect spelling 'accordian' and update if you are using this icon ([PR alphagov#345](alphagov/govuk_frontend_toolkit#345)) And two minor changes: - Amend GOVUK.StickAtTopWhenScrolling to resize the sticky element and shim when the .js-sticky-resize class is set ([PR alphagov#343](alphagov/govuk_frontend_toolkit#343)) - Allow custom options in GOVUK.analytics.trackPageview ([alphagov#332](alphagov/govuk_frontend_toolkit#332))
I'd like to close this issue if possible. The phase banner was removed from GOV.UK elements, it fixed part of this issue. Is there agreement that the breadcrumb should sit outside of the Please let me know which you would prefer @aduggin, @accessiblewebuk, @tombye. |
Yes, I still think that the breadcrumbs should be outside the and matching gov.uk is important for consistency. |
The
<main>
tag currently wraps both the main content area and the phase banner. This means when moving through pages by keyboard only using the skiplink you have to pass the phase banner every time.I suggest we replace the
<main>
tag with a wrapper div to establish the central column and start<main>
after the phase banner instead, as a child of the wrapper div. This would allow users to skip directly to the page content.There would have to be some debate around whether or not to move the breadcrumbs outside of
<main>
too. www.gov.uk does this but I'm unsure it's the best approach as they can be specific to the page and the purpose of skiplinks is to allow keyboard users to avoid content repeated across pages.The text was updated successfully, but these errors were encountered: