Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify node dependency using caret notation #562

Merged
merged 2 commits into from
Jul 24, 2018

Commits on Jul 23, 2018

  1. Specify node dependency using caret notation

    This fixes an issue when deploying to CloudFoundry instances (such as GOV.UK PaaS) where the buildpack fails on the semver range:
    
    ```
       -----> Nodejs Buildpack version 1.6.28
       -----> Installing binaries
              engines.node (package.json): >=8.9.1 <9.0
              engines.npm (package.json): unspecified (use default)
              **WARNING** Dangerous semver range (>) in engines.node. See: http://docs.cloudfoundry.org/buildpacks/node/node-tips.html
              **ERROR** Unable to install node: improper constraint: >=8.9.1 <9.0
       Failed to compile droplet: Failed to run all supply scripts: exit status 14
    ```
    
    Using ^8.9.1 instead which is semantically equivalent (any version greater than 8.9.1 but less than 9.0) allows the app to deploy successfully:
    
    ```
       -----> Nodejs Buildpack version 1.6.28
       -----> Installing binaries
              engines.node (package.json): ^8.9.1
              engines.npm (package.json): unspecified (use default)
       -----> Installing node 8.11.3
              Download [https://buildpacks.cloudfoundry.org/dependencies/node/node-8.11.3-linux-x64-34b80d71.tgz]
    ```
    36degrees committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    c887dab View commit details
    Browse the repository at this point in the history
  2. Document in changelog

    36degrees committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    a63785d View commit details
    Browse the repository at this point in the history