Specify node dependency using caret notation #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue when deploying to CloudFoundry instances (such as GOV.UK PaaS) where the buildpack fails on the semver range:
```
-----> Nodejs Buildpack version 1.6.28
-----> Installing binaries
engines.node (package.json): >=8.9.1 <9.0
engines.npm (package.json): unspecified (use default)
**WARNING** Dangerous semver range (>) in engines.node. See: http://docs.cloudfoundry.org/buildpacks/node/node-tips.html
**ERROR** Unable to install node: improper constraint: >=8.9.1 <9.0
Failed to compile droplet: Failed to run all supply scripts: exit status 14
```
Using ^8.9.1 instead which is semantically equivalent (any version greater than 8.9.1 but less than 9.0) allows the app to deploy successfully:
```
-----> Nodejs Buildpack version 1.6.28
-----> Installing binaries
engines.node (package.json): ^8.9.1
engines.npm (package.json): unspecified (use default)
-----> Installing node 8.11.3
Download [https://buildpacks.cloudfoundry.org/dependencies/node/node-8.11.3-linux-x64-34b80d71.tgz]
```
36degrees
force-pushed
the
update-node-dependency
branch
from
d0acd5f
to
c887dab
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when deploying to CloudFoundry instances (such as GOV.UK PaaS) where the buildpack fails on the semver range:
Using
^8.9.1instead which is semantically equivalent (any version greater than 8.9.1 but less than 9.0) allows the app to deploy successfully:node >=8.9.1 <9.0: 8.11.3node ^8.9.1: 8.11.3