Remove jQuery from default installation

[nataliecarey]

This removes jQuery. If the user misses it they can install the latest version using npm install jquery, if they have problems with the latest version they can continue using the same version by using npm install jquery@1.11.3. They can also choose their own version.

Extensions may rely on jQuery under the cover but shouldn't expose it to the user, the user should be in control of their own jQuery version but not get one by default.

Closes #1420.

Closes #1448.

[lfdebrux]

I tested this locally using the step by step (v1) example, I found that as expected with this code checked out the step by step page didn't work, but after running npm install jquery it did. Very nice!

As a side note I also tested this commit with the changes to use the step by step extension, to verify that the scoped jQuery and packaged jQuery did not conflict. I found no issues.

Once the unit tests are fixed I think this is ready to merge.

[BenSurgisonGDS]

The hardcoded fileSystemPath needs to be calculated with path.resolve.

[BenSurgisonGDS]

I think the hard coded fileSystemPath should be: path.resolve('node_modules', 'jquery', 'dist')

The test should be:

      it('should not include public URLs for jQuery if it is not installed', () => {
        expect(extensions.getPublicUrlAndFileSystemPaths('assets')).toEqual([{
          fileSystemPath: path.resolve('node_modules', 'jquery', 'dist'),
          publicUrl: '/extension-assets/jquery/dist'
        }])
      })

[nataliecarey]

Haha, yeah, I think it shows that I was writing this at the end of the day :)

[BenSurgisonGDS]

Looks good

[BenSurgisonGDS]

Issue with step by step because jquery isn't there

[joelanman]

will users get this change as part of the update process?

[lfdebrux]

No