Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep jQuery as dependency of prototype when migrating to v13 #1731

Closed
1 task done
lfdebrux opened this issue Oct 28, 2022 · 2 comments · Fixed by #1754
Closed
1 task done

Keep jQuery as dependency of prototype when migrating to v13 #1731

lfdebrux opened this issue Oct 28, 2022 · 2 comments · Fixed by #1754
Assignees
Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve.
Milestone

Comments

@lfdebrux
Copy link
Member

lfdebrux commented Oct 28, 2022

note - look at Step by step ticket before this one: #1730

What

Add jQuery to the list of dependencies of v12 that are not included in new prototypes with v13, but which we keep for the user when migrating an old prototype.

Why

If a user is relying on jQuery for an old prototype, we don't want them to have to figure out why their prototype isn't working when they've migrated it.

Who needs to work on this

Developer

Who needs to review this

Developer

Done when

  • Prototypes migrated with CLI tool have jQuery as a dependency at the end
@joelanman
Copy link
Contributor

I'm not sure how easy this might be - jQuery wasn't a plug-in previously, it was included in the assets folder and made available at /public/... So even if we add jQuery as a plug-in, wouldn't it still be broken unless changes were made to the jquery path in the front end?

Another point is I'm not sure how many people actually use jQuery, my impression is its quite low

@lfdebrux
Copy link
Member Author

lfdebrux commented Oct 31, 2022

I'm not sure how easy this might be - jQuery wasn't a plug-in previously, it was included in the assets folder and made available at /public/... So even if we add jQuery as a plug-in, wouldn't it still be broken unless changes were made to the jquery path in the front end?

We support jQuery specially, see #1478

@lfdebrux lfdebrux added this to the v13 milestone Oct 31, 2022
@joelanman joelanman added 🕔 Hours A well understood issue which we expect to take less than a day to resolve. and removed awaiting triage labels Nov 1, 2022
@lfdebrux lfdebrux self-assigned this Nov 8, 2022
@lfdebrux lfdebrux closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants