Update tabs spacing #886
Merged
Update tabs spacing #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-886
NickColley
reviewed
Jul 12, 2018
src/components/tabs/tabs.yaml
Outdated
| @@ -8,7 +8,7 @@ examples: | |||
| panel: | |||
| html: | | |||
| <h2 class="govuk-heading-l">Past day</h2> | |||
| <table class="govuk-table"> | |||
| <table class="govuk-table govuk-!-margin-bottom-0"> | |||
There was a problem hiding this comment.
This works, just a question: In the conditional reveal I think we do this to any :last-child, should we consider doing that here too?
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-886
dashouse
force-pushed
the
update-tabs-spacing
branch
from
ef50f88 to
1d321d9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-886
dashouse
force-pushed
the
update-tabs-spacing
branch
from
1d321d9 to
f213136
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-886
|
The padding left and right was as it was so that the text in the first tab vertically aligned with the text (or whatever) inside the panel. This was something @joelanman originally asked me to do. I don't mind the change, but mentioning just in case. |
|
@adamsilver @joelanman Ok great, sorry for the slight alignment issue (no pun intended). I'll keep the top/bottom margin and check in with Joe on the left and right...makes sense |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-886
dashouse
force-pushed
the
update-tabs-spacing
branch
from
8ba13b5 to
2ce39d8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-886
|
Actually this is the right thing to do, have updated this to only affect the top/bottom relationship :) |
36degrees
reviewed
Jul 13, 2018
NickColley
force-pushed
the
update-tabs-spacing
branch
from
2ce39d8 to
d159925
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-886
NickColley
force-pushed
the
update-tabs-spacing
branch
from
d159925 to
e2523fc
Compare
|
Thanks @dashouse 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates internal padding of tab content in the Tabs component (backlog alphagov/govuk-design-system-backlog#100)
Before
After
This required margin to be defined on the tab container at mobile breakpoint to separate content.
I also increased the space below the contents menu.
Have also used the
:last-childsolution from conditional radios and checkboxes to remove the margin-bottom of the last item that is inside the container to avoid double margin.