Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing full stops in macro option descriptions #4151

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Fix missing full stops in macro option descriptions #4151

merged 3 commits into from
Aug 31, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Aug 31, 2023 •
edited
Loading

Just a few more typos and missing full stops spotted in recent testing

Builds on other fixes in #4122

Description with missing full stop

@colinrotherham colinrotherham added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) documentation User requests new documentation or improvements to existing documentation labels Aug 31, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4151 August 31, 2023 11:03 Inactive
colinrotherham
colinrotherham commented Aug 31, 2023
View reviewed changes
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.yaml
@@ -26,19 +26,19 @@ params:
- name: activatedText
type: string
required: false
description: Text announced by screen readers when Exit this Page has been activated via the keyboard shortcut. Defaults to 'Exiting page.'
description: Text announced by screen readers when Exit this Page has been activated via the keyboard shortcut. Defaults to 'Loading.'.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owenatgov @querkmachine Think this one was missed from #3266 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 72.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 67.95 KiB
packages/govuk-frontend/dist/govuk/all.mjs 4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 34.28 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 64.5 KiB
components/accordion/accordion.mjs 20.86 KiB
components/button/button.mjs 3.67 KiB
components/character-count/character-count.mjs 20.46 KiB
components/checkboxes/checkboxes.mjs 4.37 KiB
components/error-summary/error-summary.mjs 4.96 KiB
components/exit-this-page/exit-this-page.mjs 15.42 KiB
components/header/header.mjs 2.3 KiB
components/notification-banner/notification-banner.mjs 3.5 KiB
components/radios/radios.mjs 3.37 KiB
components/skip-link/skip-link.mjs 2.12 KiB
components/tabs/tabs.mjs 8.04 KiB

View stats and visualisations on the review app

Action run for d372cfb

@colinrotherham colinrotherham added this to the v5.0 milestone Aug 31, 2023
owenatgov
owenatgov approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪🏻

packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.yaml
@@ -26,19 +26,19 @@ params:
- name: activatedText
type: string
required: false
description: Text announced by screen readers when Exit this Page has been activated via the keyboard shortcut. Defaults to 'Exiting page.'
description: Text announced by screen readers when Exit this Page has been activated via the keyboard shortcut. Defaults to 'Loading.'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4151 August 31, 2023 16:21 Inactive
Base automatically changed from summary-list-yaml to main August 31, 2023 16:51
@colinrotherham colinrotherham merged commit 2ea8377 into main Aug 31, 2023
@colinrotherham colinrotherham deleted the descriptions-yaml branch August 31, 2023 17:21
colinrotherham added a commit that referenced this pull request Sep 27, 2023
@colinrotherham
Merge pull request #4151 from alphagov/descriptions-yaml
68a85e4 
Fix missing full stops in macro option descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenatgov owenatgov owenatgov approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) documentation User requests new documentation or improvements to existing documentation
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@colinrotherham @owenatgov @govuk-design-system-ci