Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Summary list actions for both rows and cards are consistent #4122

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Aug 24, 2023

Macro options for Summary list rows[].actions and card.actions are shared

This PR ensures they match in both description and option order

As mentioned at Show & Tell this morning, we've realised we already knew that Design System HTML will include duplicate IDs for nested options with the same key names when updating to GOV.UK Frontend v5, but we can fix this separately

Update: Now fixed in: alphagov/govuk-design-system#2260

Nested options

For context, we expanded older key, value and actions nested options recently:

Which matches how newer options like card are nested:

@colinrotherham colinrotherham added documentation User requests new documentation or improvements to existing documentation summary list labels Aug 24, 2023
@colinrotherham colinrotherham added this to the v5.0 milestone Aug 24, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4122 August 24, 2023 12:24 Inactive
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 72.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 67.95 KiB
packages/govuk-frontend/dist/govuk/all.mjs 4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 34.28 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 64.5 KiB
components/accordion/accordion.mjs 20.86 KiB
components/button/button.mjs 3.67 KiB
components/character-count/character-count.mjs 20.46 KiB
components/checkboxes/checkboxes.mjs 4.37 KiB
components/error-summary/error-summary.mjs 4.96 KiB
components/exit-this-page/exit-this-page.mjs 15.42 KiB
components/header/header.mjs 2.3 KiB
components/notification-banner/notification-banner.mjs 3.5 KiB
components/radios/radios.mjs 3.37 KiB
components/skip-link/skip-link.mjs 2.12 KiB
components/tabs/tabs.mjs 8.04 KiB

View stats and visualisations on the review app


Action run for 59390ff

@colinrotherham
Copy link
Contributor Author

As mentioned at Show & Tell this morning, we've realised that Design System HTML will include duplicate IDs for nested options with the same key names when updating to GOV.UK Frontend v5, but we can fix this separately

A quick fix would be to include parent key names in ID attributes --actions --card-actions

But with two identical tables named Options for actions (rows + cards) we should write up an issue

Example showing parent names included in nested options names

@querkmachine
Copy link
Member

But with two identical tables named Options for actions (rows + cards) we should write up an issue

There's an existing issue regarding the duplicate IDs here: alphagov/govuk-design-system#2260

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4122 August 31, 2023 10:54 Inactive
These params were duplicated between `rows[].actions` and `card.actions`
We know “of each” isn’t our favourite wording, but the two now match:

1. The actions of each row.
2. The actions of each summary card.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4122 August 31, 2023 16:21 Inactive
@colinrotherham colinrotherham merged commit de655b0 into main Aug 31, 2023
@colinrotherham colinrotherham deleted the summary-list-yaml branch August 31, 2023 16:51
colinrotherham added a commit that referenced this pull request Sep 27, 2023
Ensure Summary list `actions` for both rows and cards are consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User requests new documentation or improvements to existing documentation summary list
Projects
Development

Successfully merging this pull request may close these issues.

4 participants