-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Summary list actions
for both rows and cards are consistent
#4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
added
documentation
User requests new documentation or improvements to existing documentation
summary list
labels
Aug 24, 2023
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4122
August 24, 2023 12:24
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 59390ff |
There's an existing issue regarding the duplicate IDs here: alphagov/govuk-design-system#2260 |
colinrotherham
force-pushed
the
summary-list-yaml
branch
from
August 31, 2023 10:54
2ced280
to
3f91e77
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4122
August 31, 2023 10:54
Inactive
romaricpascal
approved these changes
Aug 31, 2023
These params were duplicated between `rows[].actions` and `card.actions`
We know “of each” isn’t our favourite wording, but the two now match: 1. The actions of each row. 2. The actions of each summary card.
colinrotherham
force-pushed
the
summary-list-yaml
branch
from
August 31, 2023 16:21
3f91e77
to
59390ff
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4122
August 31, 2023 16:21
Inactive
colinrotherham
added a commit
that referenced
this pull request
Sep 27, 2023
Ensure Summary list `actions` for both rows and cards are consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
User requests new documentation or improvements to existing documentation
summary list
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro options for Summary list
rows[].actions
andcard.actions
are sharedThis PR ensures they match in both description and option order
As mentioned at Show & Tell this morning,
we've realisedwe already knew that Design System HTML will include duplicate IDs for nested options with the same key names when updating to GOV.UK Frontend v5, but we can fix this separatelyUpdate: Now fixed in: alphagov/govuk-design-system#2260
Nested options
For context, we expanded older
key
,value
andactions
nested options recently:Which matches how newer options like
card
are nested: