Remove govuk-focusable, govuk-focusable-fill mixins, introduce govuk-focus-text mixin.
#1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've renamed the focus mixin since it's now only used, with the `:focus` selector rather than having it baked in. https://gist.github.com/nickcolley/791d084ff263786acb433ed0bd13c381
This is going to be removed so inline the needed CSS declarations.
For many use cases this can replaced with
`&:focus { @include govuk-focused-text; }`
We are removing this mixin as it's no longer useful. Many of the focus states now include edge cases or logic that'd require more focused mixins or parameters passed to the current mixins. We're removing this mixin but may introduce more explicit mixins in the future for things like inputs.
We are removing this mixin as it's no longer useful. Many of the focus states now include edge cases or logic that'd require more focused mixins or parameters passed to the current mixins. We're removing this mixin but may introduce more explicit mixins in the future for things like inputs.
This is consistent with the mixin name changes
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1361
NickColley
changed the title
govuk-focusable, govuk-focusable-fill mixins, introduce govuk-focus-text mixin.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1361
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1361
NickColley
force-pushed
the
rework-focus-mixins
branch
from
0b23b26 to
8d0be8a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1361
NickColley
force-pushed
the
rework-focus-mixins
branch
from
8d0be8a to
944bfaf
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1361
aliuk2012
reviewed
May 22, 2019
We don't need to set this to zero everywhere, only on some inputs. alphagov/govuk_elements#346
NickColley
force-pushed
the
rework-focus-mixins
branch
from
944bfaf to
b1b9e60
Compare
|
@aliuk2012 updated based on your feedback thank you :) |
aliuk2012
approved these changes
May 22, 2019
aliuk2012
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements option 2 from the mixins proposal: https://gist.github.com/nickcolley/791d084ff263786acb433ed0bd13c381
focusablefile tofocusedgovuk-focusableandgovuk-focusable-fillgovuk-focused-textSince the new focus styles are harder to abstract we're removing the mixins apart from the focus that is applied to text, for example links.
Closes #1344 (see for more details)