Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on how the mixins should change for new focus styles #1344

Closed
2 tasks done
NickColley opened this issue May 14, 2019 · 0 comments
Closed
2 tasks done

Decide on how the mixins should change for new focus styles #1344

NickColley opened this issue May 14, 2019 · 0 comments
Assignees

Comments

@NickColley
Copy link
Contributor

NickColley commented May 14, 2019

What

Make a decision on how the mixins should change with the new focus states in mind.

Why

Since we've changed the focus styles the old mixins are not necessarily fit for purpose and need to be removed or updated.

Until now we have been adjusting the temporary mixins as needed, but now we have all the new focus states merged we can look at them all together.

Mark Green is also going to be writing guidance around these mixins so we should include him wherever possible in this process.

We're updating the focus style as part of making the Design System meet WCAG 2.1 – specifically with regard to WCAG 2.1 1.4.11 Non-Text Contrast (#1137).

Who needs to know about this

  • Developers
  • Mark Green
  • Dave House
  • Amy Hupe (optional)

Done when

  • Put together a proposal for what the new mixins should look like
  • Run a meeting to run through proposal and get feedback from the team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants