Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brazilian Phrases #1974

Merged
merged 10 commits into from
Apr 9, 2023
Merged

Update Brazilian Phrases #1974

merged 10 commits into from
Apr 9, 2023

Conversation

crashzk
Copy link
Contributor

@crashzk crashzk commented Apr 2, 2023

@peace-maker peace-maker added the i18n translation phrases label Apr 4, 2023
@peace-maker
Copy link
Member

@Tiagoquix Do you have concerns with these changes?

@Tiagoquix
Copy link

@Tiagoquix Do you have concerns with these changes?

Yes. Most of changes are to just make texts uppercase, which isn't common nor the standard in Brazilian Portuguese. We tend to keep things lowercase whenever possible.

There's also some "un-translations":
image

"slot" is in english; "reserva de vaga" is correct ("vaga reservada" would also be).

The OP also removed the translation for "AllTalk", which I don't think is necessary.
image

OP has also tried to "un-translate" some SourceBans phrases, as it can be seen here:

https://github.com/sbpp/sourcebans-pp/pulls?q=is%3Apr+author%3Acrashzk

Originally, sbpp/sourcebans-pp#667 was merged, which was later reverted due to a request of mine: sbpp/sourcebans-pp#675.

I translated many others Team Fortress 2's plugins as well, in addition to having actively participated in the Brazilian Portuguese Steam Translation Server in the past.

Therefore, I can confidently say that this pull request will hurt the translation more than actually improve it.

@crashzk
Copy link
Contributor Author

crashzk commented Apr 8, 2023

@Tiagoquix I understand your point, in this case it would just be a translation that I already use in my CSGO servers. In any case, I can convert it to leave it translated again as before, in which case I only sent what I already had.

Anyway, as soon as possible I'll update again and leave it in lower case.

AllTalk question, I believe we can leave it translated right then and remove (AllTalk) from the sentence, right?

@crashzk
Copy link
Contributor Author

crashzk commented Apr 8, 2023

Done, let me know if I need to change anything else.

@Tiagoquix
Copy link

About AllTalk: I would prefer to keep "(AllTalk)" in parenthesis.

About "Conexão cancelada devido a vaga reservada", I would suggest you to change it to "Conexão cancelada devido a uma vaga reservada" or "Conexão cancelada devido a uma reserva de vaga".

The rest of the changes look good to me now.

@crashzk
Copy link
Contributor Author

crashzk commented Apr 8, 2023

Done, all right now, so I believe.

Note: Leaving the AllTalk message translated and also putting (AllTalk) in the sentence, I believe it applies what you said, translates something and leaves others in English.

@Tiagoquix
Copy link

Everything is OK for me now. Thank you for your willingness!

@crashzk crashzk requested a review from psychonic April 8, 2023 12:39
@psychonic psychonic merged commit b1b9939 into alliedmodders:master Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n translation phrases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants