-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Brazilian Phrases #1974
Update Brazilian Phrases #1974
Conversation
@Tiagoquix Do you have concerns with these changes? |
Yes. Most of changes are to just make texts uppercase, which isn't common nor the standard in Brazilian Portuguese. We tend to keep things lowercase whenever possible. There's also some "un-translations": "slot" is in english; "reserva de vaga" is correct ("vaga reservada" would also be). The OP also removed the translation for "AllTalk", which I don't think is necessary. OP has also tried to "un-translate" some SourceBans phrases, as it can be seen here: https://github.com/sbpp/sourcebans-pp/pulls?q=is%3Apr+author%3Acrashzk Originally, sbpp/sourcebans-pp#667 was merged, which was later reverted due to a request of mine: sbpp/sourcebans-pp#675. I translated many others Team Fortress 2's plugins as well, in addition to having actively participated in the Brazilian Portuguese Steam Translation Server in the past. Therefore, I can confidently say that this pull request will hurt the translation more than actually improve it. |
@Tiagoquix I understand your point, in this case it would just be a translation that I already use in my CSGO servers. In any case, I can convert it to leave it translated again as before, in which case I only sent what I already had. Anyway, as soon as possible I'll update again and leave it in lower case. AllTalk question, I believe we can leave it translated right then and remove (AllTalk) from the sentence, right? |
Done, let me know if I need to change anything else. |
About AllTalk: I would prefer to keep "(AllTalk)" in parenthesis. About "Conexão cancelada devido a vaga reservada", I would suggest you to change it to "Conexão cancelada devido a uma vaga reservada" or "Conexão cancelada devido a uma reserva de vaga". The rest of the changes look good to me now. |
Done, all right now, so I believe. Note: Leaving the AllTalk message translated and also putting (AllTalk) in the sentence, I believe it applies what you said, translates something and leaves others in English. |
Everything is OK for me now. Thank you for your willingness! |
https://github.com/orgs/alliedmodders/projects/1/views/1?pane=issue&itemId=24307179