-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix npm install #293
Fix npm install #293
Conversation
Think it's reasonable to put together a test to make sure this bug doesn't show up again? |
Want me to refactor |
Let's do a separate test file for that. |
f.write(process.stdout.decode('utf-8')) | ||
elif process: | ||
print_path_red("An error occurred while running: $", command) | ||
if process: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert this conditional back to the way it was before. I think that was easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? I changed it to this so that it would differentiate between a package manager not existing on the system and an actual error occurring. As is, if you don't have any package managers, you're getting a bunch of red-colored errors spit out at you rather than a simple warning saying it doesn't exist.
Nice fix. Few small changes and I'll merge this in. |
Addressed in #299 |
This addresses #148.