Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing npm Reinstall #148

Closed
alichtman opened this issue Oct 27, 2018 · 2 comments
Closed

Failing npm Reinstall #148

alichtman opened this issue Oct 27, 2018 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed reinstallation

Comments

@alichtman
Copy link
Owner

image
@alichtman alichtman added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers reinstallation labels Oct 27, 2018
@alichtman alichtman modified the milestone: v2.0 Oct 27, 2018
@tim-coutinho
Copy link
Contributor

This has to do with the way subprocess.run handles pipes. See https://security.openstack.org/guidelines/dg_avoid-shell-true.

The way run_cmd_write_stdout and run_cmd handle input and output will have to be refactored, or another function added along the lines of run_cmd_return_stdout that handles chaining piped commands.

This was referenced Dec 25, 2020
Closed
Closed
@alichtman
Copy link
Owner Author

Addressed in #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed reinstallation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tim-coutinho @alichtman