fix(vue): don't spread in ais-state-results

packages/vue-instantsearch/src/components/StateResults.vue

@@ -1,6 +1,6 @@
 <template>
   <div :class="suit()" v-if="state && state.state && state.results">
-    <slot v-bind="stateResults">
+    <slot v-bind="state">
       <p>
         Use this component to have a different layout based on a certain state.
       </p>
@@ -38,7 +38,6 @@ export default {
         const helper = this.getParentIndex().getHelper();
         const state = helper ? helper.state : null;
 
-        // @MAJOR no longer spread this inside `results`
         this.state = {
           results,
           state,
@@ -74,17 +73,5 @@ export default {
       },
     },
   },
-  computed: {
-    stateResults() {
-      const { results, state, status, error } = this.state;
-      return {
-        ...results,
-        results,
-        state,
-        status,
-        error,
-      };
-    },
-  },
 };
 </script>

packages/vue-instantsearch/src/components/__tests__/StateResults.js

@@ -53,7 +53,6 @@ it('gives state & results to default slot', () => {
   mount(StateResults, {
     scopedSlots: {
       default: (props) => {
-        expect(props).toEqual(expect.objectContaining(results));
         expect(props.results).toEqual(results);
         expect(props.state).toEqual(state);
         expect(props.status).toEqual('idle');
@@ -182,77 +181,3 @@ it('allows default slot to render whatever they want (falsy query)', () => {
 </div>
 `);
 });
-
-describe('legacy spread props', () => {
-  it('allows default slot to render whatever they want (truthy query)', () => {
-    __setIndexResults({
-      query: 'q',
-      hits: [
-        { objectID: '1', name: 'one' },
-        { objectID: '2', name: 'two' },
-      ],
-      page: 1,
-    });
-    __setIndexHelper({ state: {} });
-
-    const wrapper = mount({
-      components: { StateResults },
-      template: `
-        <StateResults>
-          <template v-slot="{ query }">
-            <p v-if="query">
-              Query is here
-            </p>
-            <p v-else>
-              There's no query
-            </p>
-          </template>
-        </StateResults>
-      `,
-    });
-
-    expect(wrapper.html()).toMatchInlineSnapshot(`
-<div class="ais-StateResults">
-  <p>
-    Query is here
-  </p>
-</div>
-`);
-  });
-
-  it('allows default slot to render whatever they want (falsy query)', () => {
-    __setIndexResults({
-      query: '',
-      hits: [
-        { objectID: '1', name: 'one' },
-        { objectID: '2', name: 'two' },
-      ],
-      page: 1,
-    });
-    __setIndexHelper({ state: {} });
-
-    const wrapper = mount({
-      components: { StateResults },
-      template: `
-        <StateResults>
-          <template v-slot="{ query }">
-            <p v-if="query">
-              Query is here
-            </p>
-            <p v-else>
-              There's no query
-            </p>
-          </template>
-        </StateResults>
-      `,
-    });
-
-    expect(wrapper.html()).toMatchInlineSnapshot(`
-<div class="ais-StateResults">
-  <p>
-    There's no query
-  </p>
-</div>
-`);
-  });
-});