fix(vue): don't spread in ais-state-results #6481
Merged
+1
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer document directly using the `query` for example in the ais-state-results component, read it either from state or results. [FX-3194] BREAKING CHANGE: connectStateResults is no longer exposed from Vue InstantSearch BREAKING CHANGE: the slot in ais-state-results receives an object with `results`, `state`, `status` and `error`, no longer direct access to e.g. `query`
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fbb6eb4:
|
dhayab
approved these changes
Dec 20, 2024
Haroenv
added a commit
that referenced
this pull request
Dec 26, 2024
We no longer document directly using the `query` for example in the ais-state-results component, read it either from state or results. [FX-3194] BREAKING CHANGE: connectStateResults is no longer exposed from Vue InstantSearch BREAKING CHANGE: the slot in ais-state-results receives an object with `results`, `state`, `status` and `error`, no longer direct access to e.g. `query`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer document directly using the
queryfor example in the ais-state-results component, read it either from state or results.The
connectStateResultsconnector is removed, as we don't use it anymore but arenderlistener instead.FX-3194
BREAKING CHANGE: connectStateResults is no longer exposed from Vue InstantSearch
BREAKING CHANGE: the slot in ais-state-results receives an object with
results,state,statusanderror, no longer direct access to e.g.query