feat: composition #6437
Merged
feat: composition #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-krebs
added
the
🚨 DO NOT MERGE
Haroenv
reviewed
Nov 18, 2024
Haroenv
reviewed
Nov 19, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7b5019:
|
e-krebs
force-pushed
the
feat/composition
branch
3 times, most recently
from
37c1d4a to
7b6e05b
Compare
Haroenv
reviewed
Nov 19, 2024
Haroenv
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
Haroenv
reviewed
Nov 20, 2024
|
@Haroenv as discussed, this should be ready to merge but we won't merge for now (and instead use this as a base branch for the whole feature implementation) so I'm keeping the "do not merge" label |
Haroenv
reviewed
Nov 20, 2024
Haroenv
reviewed
Nov 20, 2024
Haroenv
reviewed
Nov 20, 2024
Haroenv
approved these changes
Nov 20, 2024
Haroenv
approved these changes
Nov 21, 2024
|
just as draft as while it's approved, we're not merging until you want a release |
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
feat: forbid adding an index widget when on a composition-based implementation
* feat: make vue compatible with composition * chore: increase vue2 package size 🤏 * chore(lint): allow console.error * feedback: do not add warning
* feat: add support for disjunctive facets with Composition API * fix: no lambda * fix: no string template * Update requestBuilder.js Co-authored-by: Haroen Viaene <hello@haroen.me> --------- Co-authored-by: Haroen Viaene <hello@haroen.me>
* feat: add searchForCompositionFacetValues in the helper * feat: plug searchForFacetValues for Composition * fix: js syntax * fix: bundlesizes * Update packages/algoliasearch-helper/src/algoliasearch.helper.js Co-authored-by: Haroen Viaene <hello@haroen.me> --------- Co-authored-by: Haroen Viaene <hello@haroen.me>
e-krebs
force-pushed
the
feat/composition
branch
from
3ce2711 to
0db51c5
Compare
…acetValues (#6506) * example * clean: revert temporary examples change * fix: query & searchQuery where mixed * fix: rebase error
* feat: make composition work server-side * feat: add proper typing for CompositionClient
Merged
fix: a small type mistake that went through the cracks
Haroenv
approved these changes
Jan 8, 2025
dhayab
approved these changes
Jan 13, 2025
@dhayab that's the plan (at least for react & maybe vanilla js too). |
dhayab
approved these changes
Jan 13, 2025
Haroenv
removed
the
🚨 DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR currently adds support for Composition using a (currently not published yet) Composition API Client:
compositionIDoptional parameter when initializing InstantSearch (this PR)