feat: add searchForFacetValues for composition #6489
Merged
+103
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-krebs
commented
Dec 20, 2024
Comment on lines
+592
to
+595
| if (this.compositionID) { | ||
| mainHelper.searchForFacetValues = | ||
| mainHelper.searchForCompositionFacetValues.bind(mainHelper); | ||
| } |
There was a problem hiding this comment.
I went with this approach because it allows things to be completely transparent for connectRefinementList, but I'm open to suggestions
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d594f3:
|
Haroenv
reviewed
Dec 20, 2024
Co-authored-by: Haroen Viaene <hello@haroen.me>
Haroenv
approved these changes
Dec 21, 2024
|
Once we're aiming for GA with composition, I'd like to see a plan how the search and sffv methods could be the same between search and composition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adding support for
SearchForFacetValueswhen using Composition APIEMERCH-1745
Result
there is a small bug on the API side which result in highlighting not working as expecting in the facet values, but that doesn't affect the implementation as the fix should be transparent API-wise