feat(preset-algolia): attach algolia credentials on hits #1117
Conversation
dhayab
requested review from
a team,
FabienMotte and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1296bc9:
|
packages/autocomplete-plugin-algolia-insights/src/types/AlgoliaInsightsHit.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
| export function getAppIdAndApiKey( | ||
| searchClient: SearchClient | ||
| ): { appId: string; apiKey: string } { | ||
| const { headers, queryParameters } = searchClient.transporter; |
There was a problem hiding this comment.
Hi @dhayab, I am not sure if we are using autocomplete incorrectly, but we ran into an issue where the transporter wasn't checked and the JS code was trying to pull headers from undefined. Could you help with this? We have a fix in a place where we are using version 1.8.3 of autocomplete-preset-algolia. We could be using it wrong, I am not sure.
There was a problem hiding this comment.
Hi Bryan, this is probably because you have the v3 of algoliasearch in your dependencies. Autocomplete relies on the v4, which is what causes the issue right now.
If you're not using the javascript search client directly, you can safely update it to the latest v4 version as InstantSearch and Autocomplete have support for it.
This PR adds an
__autocomplete_algoliaResultsMetadataproperty on each hit returned from an Algolia source, that includes the credentials of the application it comes from. This will help us send events to the appropriate location at a later stage.FX-2276