Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preset-algolia): attach algolia credentials on hits #1117
feat(preset-algolia): attach algolia credentials on hits #1117
Changes from 4 commits
ff595a0
c511d8f
aa60dda
ccc3c5e
1296bc9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dhayab, I am not sure if we are using autocomplete incorrectly, but we ran into an issue where the
transporter
wasn't checked and the JS code was trying to pull headers fromundefined
. Could you help with this? We have a fix in a place where we are using version 1.8.3 ofautocomplete-preset-algolia
. We could be using it wrong, I am not sure.https://github.com/algolia/algoliasearch-shopify/pull/1520
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Bryan, this is probably because you have the v3 of
algoliasearch
in your dependencies. Autocomplete relies on the v4, which is what causes the issue right now.If you're not using the javascript search client directly, you can safely update it to the latest v4 version as InstantSearch and Autocomplete have support for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh wonderful thank you!