feat(insights): add "insights" option for automatic events #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
force-pushed
the
feat/automatic-events
branch
from
972e806
to
a27990d
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd9dea4:
|
Haroenv
force-pushed
the
feat/automatic-events
branch
2 times, most recently
from
a0b1d30
to
a727066
Compare
Haroenv
changed the title
Haroenv
force-pushed
the
feat/automatic-events
branch
2 times, most recently
from
96f16de
to
78c04d2
Compare
Haroenv
added a commit
to algolia/doc-code-samples
that referenced
this pull request
Apr 21, 2023
Not done for React Native, nor React InstantSearch Core-based examples. FX-2317 Still to do: - [ ] update instantsearch version on release of algolia/instantsearch#5490 - [ ] update autocomplete on release of algolia/autocomplete#1118
Haroenv
requested review from
a team,
dhayab and
aymeric-giraudet
and removed request for
a team
sarahdayan
approved these changes
Apr 24, 2023
dhayab
approved these changes
Apr 24, 2023
Co-authored-by: Haroen Viaene <hello@haroen.me>
Default events get `autocomplete, autocomplete-internal`, custom events only get `autocomplete`. FX-2288
Haroenv
force-pushed
the
feat/automatic-events
branch
from
78c04d2
to
9b9520b
Compare
Haroenv
force-pushed
the
feat/automatic-events
branch
from
9b9520b
to
dd9dea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option "insights" to autocomplete, which will enable the insights plugin automatically. This PR also makes
insightsClientoptional, as we first will attempt to retrieve it from window.aa, and then load it from JSDelivr.Add insights option:
insightsoption to enable the Insights plugin #1121Load insights client:
search-insights@2.4.0#1109Make init optional:
Other improvements: