-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CODEOWNERS): add owners for /specs/ingestion/ #2861
Conversation
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
These teams aren't public, closing. |
we also still enforce code owners to the API clients team for now as changing a spec also impacts the documentation and the clients themselves (but I agree this can be much easier to collaborate later with teams owning their stuff!) |
@shortcuts thanks. Yeah we're just mildly concerned if we don't manage to get #2858 (for example) ready in this day cycle that we'll miss the boat on it and have to wait a round trip to get it merged. Don't suppose you have any ideas? We could try to get added to the |
Yup that make sense, if it's only for Ingestion I guess that's fine considering the low usage but we have to be careful of potential breaking changes/renames since our frontend dashboard uses it BTW the DI and API clients team are basically the same so it's fine if you don't list it as code owners since it's private |
@shortcuts in the change I included DI and EX teams just for "correctness" since it may not always be true that "BTW the DI and API clients team are basically". But, it's a moot point anyway because both teams are private so this won't work. I requested access to join: |
I guess it might be better to have a new public team for events so you can co-own the ingestion part? The project isn't super mature in term of external team contributions which could lead to unwanted changes slipping through |
🧭 What and Why
Goal: Allow EX to merge our changes without having to wait for a round trip review. Post-merge reviews are always appreciated!
Changes included: