Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CODEOWNERS): add owners for /specs/ingestion/ #2861

Closed
wants to merge 1 commit into from

Conversation

jonathaningram
Copy link

🧭 What and Why

Goal: Allow EX to merge our changes without having to wait for a round trip review. Post-merge reviews are always appreciated!

Changes included:

  • Add EX and Data Ingestion teams as owners of /specs/ingestion/

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 13, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@jonathaningram
Copy link
Author

These teams aren't public, closing.

@jonathaningram jonathaningram deleted the ingestion-owners branch March 13, 2024 00:10
@shortcuts
Copy link
Member

shortcuts commented Mar 13, 2024

we also still enforce code owners to the API clients team for now as changing a spec also impacts the documentation and the clients themselves

(but I agree this can be much easier to collaborate later with teams owning their stuff!)

@jonathaningram
Copy link
Author

@shortcuts thanks. Yeah we're just mildly concerned if we don't manage to get #2858 (for example) ready in this day cycle that we'll miss the boat on it and have to wait a round trip to get it merged. Don't suppose you have any ideas? We could try to get added to the @algolia/api-clients-automation team but it's not exactly appropriate since we only really want to be reviewing things we can review :)

@shortcuts
Copy link
Member

@shortcuts thanks. Yeah we're just mildly concerned if we don't manage to get #2858 (for example) ready in this day cycle that we'll miss the boat on it and have to wait a round trip to get it merged. Don't suppose you have any ideas? We could try to get added to the @algolia/api-clients-automation team but it's not exactly appropriate since we only really want to be reviewing things we can review :)

Yup that make sense, if it's only for Ingestion I guess that's fine considering the low usage but we have to be careful of potential breaking changes/renames since our frontend dashboard uses it

BTW the DI and API clients team are basically the same so it's fine if you don't list it as code owners since it's private

@jonathaningram
Copy link
Author

@shortcuts thanks. Yeah we're just mildly concerned if we don't manage to get #2858 (for example) ready in this day cycle that we'll miss the boat on it and have to wait a round trip to get it merged. Don't suppose you have any ideas? We could try to get added to the @algolia/api-clients-automation team but it's not exactly appropriate since we only really want to be reviewing things we can review :)

Yup that make sense, if it's only for Ingestion I guess that's fine considering the low usage but we have to be careful of potential breaking changes/renames since our frontend dashboard uses it

BTW the DI and API clients team are basically the same so it's fine if you don't list it as code owners since it's private

@shortcuts in the change I included DI and EX teams just for "correctness" since it may not always be true that "BTW the DI and API clients team are basically". But, it's a moot point anyway because both teams are private so this won't work.

I requested access to join: @algolia/api-clients-automation. I wonder if it would be OK to allow me/us in that team, under the condition that we use our powers of approval sparingly and keep in mind "careful of potential breaking changes/renames since our frontend dashboard uses it"?

@shortcuts
Copy link
Member

I requested access to join: @algolia/api-clients-automation. I wonder if it would be OK to allow me/us in that team, under the condition that we use our powers of approval sparingly and keep in mind "careful of potential breaking changes/renames since our frontend dashboard uses it"?

I guess it might be better to have a new public team for events so you can co-own the ingestion part? The project isn't super mature in term of external team contributions which could lead to unwanted changes slipping through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants