Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add ga4BigqueryExport, streaming and append options to task inputs #2858

Merged
merged 1 commit into from
Mar 13, 2024
Merged

feat(specs): add ga4BigqueryExport, streaming and append options to task inputs #2858

merged 1 commit into from
Mar 13, 2024

Conversation

JasonBerry
Copy link
Contributor

🧭 What and Why

GA4 BigQuery Export task type was added.

🎟 JIRA Ticket: EEX-1055

Changes included:

  • Add ga4BigqueryExport task type
  • Add streaming trigger type
  • Add append action type

🧪 Test

@JasonBerry JasonBerry requested a review from a team as a code owner March 12, 2024 07:40
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 12, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

jsok
jsok requested changes Mar 12, 2024
View reviewed changes
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

🚀 Deployed on https://65f1071331ed3071cda55818--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 12, 2024 07:50 Inactive
jonathaningram
jonathaningram reviewed Mar 12, 2024
View reviewed changes
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
@jonathaningram jonathaningram mentioned this pull request Mar 13, 2024
Closed
@JasonBerry JasonBerry force-pushed the EEX-1055/insights-task-creation branch from 4327b37 to 228a94b Compare March 13, 2024 01:12
jonathaningram
jonathaningram requested changes Mar 13, 2024
View reviewed changes
Copy link

@jonathaningram jonathaningram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build issue?

@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 01:53 Inactive
@JasonBerry
Copy link
Contributor Author

build issue?

It hung, just needed to be re-run.

shortcuts
shortcuts approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I fell asleep ahah ty for the contribution!

@shortcuts shortcuts merged commit c324c06 into main Mar 13, 2024
23 checks passed
@shortcuts shortcuts deleted the EEX-1055/insights-task-creation branch March 13, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@jsok jsok jsok approved these changes

@jonathaningram jonathaningram jonathaningram approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JasonBerry @algolia-bot @jonathaningram @jsok @shortcuts