Split function generic into generic types for args and return value #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this also contains #60. Feel free to merge one or both (or none 😆 ) |
|
Loving the improved typing for this one |
wbinnssmith
force-pushed
the
wbinnssmith/remove-any-types
branch
4 times, most recently
from
3b1a9da to
59bb7bc
Compare
wbinnssmith
force-pushed
the
wbinnssmith/remove-any-types
branch
from
59bb7bc to
054faed
Compare
|
This looks good to me! @TrySound can you see any issues? |
|
I plan on merging this on monday |
TrySound
suggested changes
Apr 5, 2019
| // `mixed` means that the result can be anything but needs to be checked before usage. | ||
| // As opposed to `any`, it does not compromise type-safety. | ||
| // See https://flow.org/en/docs/types/mixed/ for more. | ||
| export default function memoizeOne<TArgs: mixed[], TRet: mixed>( |
There was a problem hiding this comment.
I would use $ReadOnlyArray
alexreardon
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to specifically reference these types within
memoizeOneand is more consistent with how decorators like these are typed elsewhere [1] [2]This also has the nice side effect of removing the
anycasting on the memoized function.This is a breaking change in the case users of
memoizeOnewere specifyingResultTypespecifically rather than letting Flow infer the type of it.It also renames the input function to
inputFninstead ofresultFn, which I found confusing (I assume this stemmed from the name of the type that served to type both the input and output function). Hope that's all right.I'm very open to feedback!
Test Plan:
yarn test[1] https://github.com/flow-typed/flow-typed/blob/master/definitions/npm/lodash_v4.x.x/flow_v0.63.x-/lodash_v4.x.x.js#L789
[2] https://github.com/sindresorhus/mem/blob/master/index.d.ts#L74