Give meaningful displayNames to decorated functions
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: * Names decorated functions simply "memoized" in the case the input function is anonymous * Names decorated functions "memoized(foo)" in the case the input function has a `name` of "foo" * Names decorated functions "memoized(foo)" in the case the input function has a `displayName` of "foo", despite having a `name` of "bar". It also gives a name to the default export of `memoize-one` of "memoizeOne", as it was previously "index" in every case but the minified version, where it was the empty string and will continue to be. Upside: Makes for debugging these decorated functions much easier in debugging tools and stack traces. Downside: more checks and more names add to the size of the compiled output. Test Plan: `yarn test`. Import the `main` entry from a repl and confirm the export is named `memoizeOne`.
wbinnssmith
changed the title
displayNames to decorated functions
|
I should have mentioned that this only applies a |
wbinnssmith
force-pushed
the
wbinnssmith/naming
branch
from
ba1f8f5 to
5388c1f
Compare
wbinnssmith
force-pushed
the
wbinnssmith/naming
branch
from
5388c1f to
d827e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
nameof "foo"displayNameof "foo", despite having anameof "bar".It also gives a name to the default export of
memoize-oneof "memoizeOne", as it was previously "index" in every case but the minified version, where it was the empty string and will continue to be.Upside: Makes for debugging these decorated functions much easier in debugging tools and stack traces.
Downside: more checks and more names add to the size of the compiled output.
Test Plan:
yarn test. Import themainentry from a repl and confirm the export is namedmemoizeOne.