fixed bug on cordova accessing template via $http on local file:// ,issues with .then().catch(), $templateCache fixes. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ fixed bug on cordova accessing template via $http on local file:// +updated dependencies
substituted with proper .then with callbacks
Now we can call Notification({message:'message here!',type:'success'}),
along with old synthax Notification('message here!','success');
fixing custom template loading
done to have same tag for 0.3.3 version with angular 1.5.9 or above dependency.
MikhailRoot
changed the title
|
Good job! |
juanjoDiaz
reviewed
Dec 29, 2016
| @@ -145,7 +160,7 @@ angular.module('ui-notification').provider('Notification', function() { | |||
|
|
|||
| setCssTransitions('none'); | |||
|
|
|||
| angular.element(document.querySelector(args.container)).append(templateElement); | |||
| angular.element(document.getElementsByTagName('body')).append(templateElement); | |||
There was a problem hiding this comment.
Why is this now using the body?
What if I want to use the notification inside a modal? I prefer the flexibility of providing my own selector.
And just FYI, you can get the body using document.body
There was a problem hiding this comment.
thank you for insight, but I havent changed this line by myself. What i've done is dealing with Template loading. I'll just fix it as you've adviced. Thank you.
UPD: Fixed.
|
LGTM. I've verified this fixes the issue. Would love to have this merged! @MikhailRoot Thank you for the solution! |
This was referenced Jan 7, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we really don't need to load default template via $http service - now using $templateCache directly as we preload it in our module.