Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed success/error methods to then/catch #102

Closed
wants to merge 1 commit into from
Closed

Changed success/error methods to then/catch #102

wants to merge 1 commit into from

Conversation

smilasek
Copy link

@smilasek smilasek commented Oct 12, 2016

Changed methods success/error into then/catch to reflect bower-angular changes.

In latest release of angular 1.5.9 success/error methods has been removed, which cause that angular-ui-notification module is broken because of the following error:

TypeError: undefined is not a constructor (evaluating '$http.get(args.template,{cache: $templateCache}).success') (line 61)

@edgaraskazlauskas
Copy link

Did you test this? It doesn't seem to work.

@tonylampada tonylampada mentioned this pull request Dec 23, 2016
@alexcrack
Copy link
Owner

Fixed by merging #108

@alexcrack alexcrack closed this Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants