Fix incorrect concurrency settings for docs workflow #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris made me aware that the docs sometimes do not get deployed. This is due to the combination of the limited workflow concurrency and the condition for the deploy job. Sometimes the workflow run for a pushed tag cancels a previous run triggered by a commit pushed to main. However, the run triggered by the tag does not execute the deploy job. This change prevents a situation like this, as pushed tags won't trigger a run anymore. We could also consider aligning with our release process by deploying only when a new tag is pushed. However, there may be situations where we want to make and deploy changes unrelated to code changes in a release.
stchris
approved these changes
May 15, 2023
stchris
pushed a commit
that referenced
this pull request
Jun 16, 2023
Chris made me aware that the docs sometimes do not get deployed. This is due to the combination of the limited workflow concurrency and the condition for the deploy job. Sometimes the workflow run for a pushed tag cancels a previous run triggered by a commit pushed to main. However, the run triggered by the tag does not execute the deploy job. This change prevents a situation like this, as pushed tags won't trigger a run anymore. We could also consider aligning with our release process by deploying only when a new tag is pushed. However, there may be situations where we want to make and deploy changes unrelated to code changes in a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chris made me aware that the docs sometimes do not get deployed. This is due to the combination of the limited workflow concurrency and the condition for the deploy job. Sometimes the workflow run for a pushed tag cancels a previous run triggered by a commit pushed to main. However, the run triggered by the tag does not execute the deploy job.
This change prevents a situation like this, as pushed tags won't trigger a run anymore.
We could also consider aligning with our release process by deploying only when a new tag is pushed. However, there may be situations where we want to make and deploy changes unrelated to code changes in a release.