Skip to content

Commit

Permalink
Fix incorrect concurrency settings for docs workflow (#3054)
Browse files Browse the repository at this point in the history
Chris made me aware that the docs sometimes do not get deployed. This is due to the combination of the limited workflow concurrency and the condition for the deploy job. Sometimes the workflow run for a pushed tag cancels a previous run triggered by a commit pushed to main. However, the run triggered by the tag does not execute the deploy job.

This change prevents a situation like this, as pushed tags won't trigger a run anymore.

We could also consider aligning with our release process by deploying only when a new tag is pushed. However, there may be situations where we want to make and deploy changes unrelated to code changes in a release.
  • Loading branch information
tillprochaska authored and stchris committed Jun 16, 2023
1 parent dd7b791 commit 8b94465
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
paths:
- "docs/**"
branches:
- "**"
workflow_dispatch: {}

concurrency:
Expand Down

0 comments on commit 8b94465

Please sign in to comment.