Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to the paper #387

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

xiki-tempula
Copy link
Collaborator

@xiki-tempula xiki-tempula commented Aug 15, 2024

Fix #386

Shuai Liu is missing ORCid

@shuail

Affiliations: some of the have zip codes, some of them dont

All zip code removed

line 23-25 could be better with a general citation

Add merz2010drug

line 81-84 could be better with a general citation

Add deng2009computations

line 111 - you could remove the word 'doing'

Removed

line 182 - is it un-equilibrated or non-equilibrated?

non-equilibrated

line 198 - formatting for 'alchemlyb' is not there

Formatted

line 221 - citation, please check DOI

Added.

line 257 - citation, please recheck DOI

This is a book and I cannot find a DOI

line 271 - citation, please recheck DOI

Added

line 293 - citation, please recheck DOI

Book, cannot find DOI

some journal names are abbreviations, some are full, could you please make them consistent?

All full now.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks for the updates!

@shuail 's ORCID is https://orcid.org/0000-0002-8632-633X (as far as I can tell) but unless he tells us that he wants to use it, we should not add it.

Remove the DOI that doesn't resolve, please.

joss_paper/paper.bib Outdated Show resolved Hide resolved
@xiki-tempula xiki-tempula requested a review from orbeckst August 16, 2024 23:49
@orbeckst
Copy link
Member

@xiki-tempula wait with merging. I pinged @shuail via LinkedIn to ask if he wants the ORCID to be added.

@shuail
Copy link
Collaborator

shuail commented Aug 17, 2024

@orbeckst Hi Oliver, yes, https://orcid.org/0000-0002-8632-633X is mine ORCID, please go ahead and use this in the paper. Thx!

@orbeckst
Copy link
Member

@xiki-tempula could you please add the missing ORCID and then merge? I’m travelling and don’t have the bandwidth. Thank you!!!

@xiki-tempula xiki-tempula merged commit 1f32e88 into alchemistry:71-joss-paper Aug 17, 2024
1 check was pending
@xiki-tempula xiki-tempula deleted the feat_changes branch August 17, 2024 20:18
@xiki-tempula xiki-tempula mentioned this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants