Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to paper #386

Closed
srmnitc opened this issue Aug 15, 2024 · 4 comments
Closed

Changes to paper #386

srmnitc opened this issue Aug 15, 2024 · 4 comments

Comments

@srmnitc
Copy link

srmnitc commented Aug 15, 2024

This is part of review over at openjournals/joss-reviews#6934

Small small items from my side. Feel free to choose as needed.

  • Shuai Liu is missing ORCid
  • Affiliations: some of the have zip codes, some of them dont
  • line 23-25 could be better with a general citation
  • line 81-84 could be better with a general citation
  • line 111 - you could remove the word 'doing'
  • line 182 - is it un-equilibrated or non-equilibrated?
  • line 198 - formatting for 'alchemlyb' is not there
  • line 221 - citation, please check DOI
  • line 257 - citation, please recheck DOI
  • line 271 - citation, please recheck DOI
  • line 293 - citation, please recheck DOI
  • some journal names are abbreviations, some are full, could you please make them consistent?

Thanks a lot!

@xiki-tempula
Copy link
Collaborator

@shuail Do you mind give your ORCID, please? thank you.

@orbeckst
Copy link
Member

@xiki-tempula do you have time to address the requested changes? I am at workshops/conferences/travelling until end of August and only have very limited bandwidth.

@orbeckst orbeckst mentioned this issue Aug 15, 2024
@xiki-tempula
Copy link
Collaborator

I think I might have some time at the weekends.

@xiki-tempula
Copy link
Collaborator

@srmnitc All the changes has been addressed in #387

@srmnitc srmnitc closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants