Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes direct SettingsPanel insertion bug #7

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fixes direct SettingsPanel insertion bug #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
163b292
Fixes #6
LightTab2 Sep 29, 2024
40b6008
Updated to keep number of if statements to a minimum
albinaask Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/SEAL/visualizers/SettingsPanel.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ func _ready():

##Called on made visible.
func _on_panel_visibility_changed():
assert(settings_collection)
if is_inside_tree() && is_visible_in_tree():#fire only if made visible and in scene tree
if settings_collection && is_inside_tree() && is_visible_in_tree():#fire only if made visible and in scene tree
for child in _setting_container.get_children():
_setting_container.remove_child(child)
_group_button_dict.clear()
Expand All @@ -53,6 +52,7 @@ func _on_panel_visibility_changed():
_update_visuals()



##Internal method for adding a new group, adds a button that controls the visibility of the settings that are connected to this group.
func _add_group(group_name:String):
_group_settings_dict[group_name] = []
Expand Down