Fixes direct SettingsPanel insertion bug #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of an assertion, a normal "if" check is made
albinaask
added a commit
to LightTab2/SEAL
that referenced
this pull request
Sep 30, 2024
Solves albinaask#7 (& albinaask#14). Co-Authored-By: LightTab2 <azorro12@gmail.com>
Solves albinaask#7 (& albinaask#14). Co-Authored-By: LightTab2 <azorro12@gmail.com>
albinaask
force-pushed
the
Direct-SettingsPanel-fix
branch
from
435a32c to
40b6008
Compare
|
Thanks a lot!! I'll merge it! btw, the reason I slightly modified the code is to reduce branches. After doing some quite extensive performance testing for the 1.0 release (like 15 hours or so) after having the popup take like 150ms to happen on my laptop I didn't find a clear culprit, but concluded that if-statements in gd script are horribly slow, so I went on a mad rant to remove every one I could and swapped them for asserts (including the one causing the bug funny enough). Again. Thanks a lot for taking the time to do this. It really makes a big difference and the credit for the bug and fix is all yours, I'm just nit picking :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6.
Instead of an assertion, a normal "if" check is made.