Support nan 2 #26
Merged
Support nan 2 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the automatic changes applied, and the package dep upgraded.
The Nan::New overload used to turn a Nan::Persistent into a v8::Local doesn't return a MaybeLocal, so the call to ToLocalChecked is not required.
Closed
|
In #20 (comment) @mlevin2 reported some success with this branch. I don't know the extent of his testing. |
|
Once again, thanks for your contributions ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #23. It consists of an automated run of
upgrade-utilsfollowed by some very minor manual tweaking to make things compile. The automated conversions haven't been manually reviewed yet, at the time of this writing.