Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to nan 2 #23

Closed
gagern opened this issue Aug 31, 2015 · 6 comments
Closed

Adapt to nan 2 #23

gagern opened this issue Aug 31, 2015 · 6 comments

Comments

@gagern
Copy link
Collaborator

gagern commented Aug 31, 2015

In libxmljs/libxmljs#330 libxmljs migrated to Nan 2, and in gagern/libxmljs@f6c2c2f libxmljs-mt followed suite. This is causing some build problems, as quite a number of Nan names have changed. I wonder whether it is safe to use Nan 1 and 2 in the same library, but probably wouldn't risk it. Instead I suggest node-libxslt be moved to Nan 2 as well. There is some 1to2.js script hidden in the Nan directory tree, but so far I had found that thing caused more problems than it addressed.

@albanm
Copy link
Owner

albanm commented Aug 31, 2015

I just tried the 1to2.js tool and get a bunch of errors.

I am not in a very brave mood, I guess I will wait for the migration guide: nodejs/nan#402

@ChALkeR
Copy link

ChALkeR commented Sep 10, 2015

Adding to the list: nodejs/node#2798.

@gagern
Copy link
Collaborator Author

gagern commented Oct 12, 2015

https://nodesource.com/blog/cpp-addons-for-nodejs-v4 appears to be the official migration guide, suggesting upgrade-utils to automate large parts of the migration process. Haven't tried this yet. If someone wants to give this a shot, please do.

@gagern gagern mentioned this issue Oct 14, 2015
@gagern
Copy link
Collaborator Author

gagern commented Oct 14, 2015

I made a stab at this, see #26. Users are welcome to try with various node versions and with real life applications. I make no guarantees at all.

@tornillo
Copy link

@albanm please bump the version of module with nan 2 to install it from npm.

@albanm
Copy link
Owner

albanm commented Oct 30, 2015

Hello,

Sorry for not being very present. I am not in a good situation to work at home.

We had already talked about it, I just added you as contributor to this project and owner of the package on npm. Feel free to do what is necessary, I will catch up later.

@albanm albanm closed this as completed Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants