Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set default static/dynamic features to be empty #628

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

🐛 Set default static/dynamic features to be empty #628

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c789a6e
🐛 Set default static/dynamic features to be empty
PatrickOHara Feb 17, 2021
b852f30
Merge branch 'master' into no-dynamic-features
PatrickOHara Feb 17, 2021
13feb96
Merge branch 'master' into no-dynamic-features
PatrickOHara Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions containers/cleanair/cleanair/parsers/urbanair_parser/model/model_data_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,25 +89,12 @@ def generate_config(
show_default=True,
),
static_features: List[StaticFeatureNames] = typer.Option(
[
StaticFeatureNames.total_road_length.value,
StaticFeatureNames.total_a_road_length.value,
StaticFeatureNames.total_a_road_primary_length.value,
StaticFeatureNames.total_b_road_length.value,
StaticFeatureNames.grass.value,
StaticFeatureNames.building_height.value,
StaticFeatureNames.water.value,
StaticFeatureNames.park.value,
StaticFeatureNames.max_canyon_narrowest.value,
StaticFeatureNames.max_canyon_ratio.value,
],
help="Features to predict on",
[], help="Spatial features that do not change over time", show_default=True,
),
dynamic_features: List[DynamicFeatureNames] = typer.Option(
[
DynamicFeatureNames.max_n_vehicles.value,
DynamicFeatureNames.avg_n_vehicles.value,
]
[],
help="Features that change over time such as average number of vehicles. Default is no dynamic features.",
show_default=True,
),
feature_buffer: List[FeatureBufferSize] = typer.Option(
["1000", "500"], help="Size of buffer for features", show_default=True
Expand Down