Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set default static/dynamic features to be empty #628

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PatrickOHara
Copy link
Collaborator

Summary

Previously there way no way to specify that the model should run with no dynamic/static features.
This PR sets the default to run with no features.
One must explicitly pass the features they want to run with.

Type of change

  • Bug fix
  • New feature
  • Infrastructure
  • API
  • Pipeline

Additional dependencies

Tests

How has the code been tested?

Issues fixes

List any issues this closes:

Checklist

Please ensure you have done the following:

  • Code conforms to the projects style guidelines

  • New code documented using google docstyle

  • Updated documentation of any changed code

  • Any additional dependencies have been added to the appropriate location (e.g. setup.py or requirements.txt)

  • Unit tests written and passing on local database. Tests should prove that fix is effective or new feature works as expected

  • Code needs to run on the cluster? Tag database administrator in the pull request review to configure.

Reviewer

@jamesbrandreth
Copy link
Contributor

scripts/mrdpg.sh doesn't specify any features, so might fail with this update?

Copy link
Contributor

@jamesbrandreth jamesbrandreth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much cleaner.

Do update mrgdp.sh if it's still wanted though.

@PatrickOHara
Copy link
Collaborator Author

scripts/mrdpg.sh doesn't specify any features, so might fail with this update?

Acutally by not specifying features this should remove any bugs with dynamic features that might be lurking on the model side.

We can come back and add static features later once we have the model running daily

@OscartGiles OscartGiles removed their request for review June 12, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants