Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: A few more docker-compose #951

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Aug 8, 2023

Follow up on #890

Copy link
Contributor

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't update these, as I'd expect that people only have one docker-compose locally, and the difference seemed to be more of a quirk of the github actions runner. But using the newer docker compose syntax makes sense.

@patriknw
Copy link
Member Author

patriknw commented Aug 8, 2023

ok, let's use docker compose in samples if that is the new way

@patriknw patriknw merged commit 0ed025c into main Aug 8, 2023
@patriknw patriknw deleted the wip-docker-compose-patriknw branch August 8, 2023 09:34
@patriknw patriknw added this to the 1.5.0-M1 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants