chore: docker-compose postgres healthcheck #890
Conversation
patriknw
commented
May 10, 2023
patriknw
commented
- instead of sleep in CI
* instead of sleep in CI
| docker-compose -f docker-files/docker-compose-postgres.yml up -d | ||
| # TODO: could we poll the port instead of sleep? | ||
| sleep 10 | ||
| docker-compose -f docker-files/docker-compose-postgres.yml up --build --detach --wait |
There was a problem hiding this comment.
I think that --build is not needed and --wait implies --detach
so docker-compose up --wait should be enough
There was a problem hiding this comment.
Yeah, --build is only if you need it to first build the image from a Dockerfile.
|
Same problem as in akka/akka-persistence-r2dbc#401 |
|
Have got this working for akka/akka-persistence-r2dbc#437. Where |
This reverts commit 9515620.
| @@ -248,7 +248,7 @@ your own workstation. Docker, a JDK and @java[maven]@scala[sbt] is all that need | |||
| 1. Start a local PostgresSQL server on default port 5432. The included `docker-compose.yml` starts everything required for running locally. | |||
|
|
|||
| ```shell | |||
| docker-compose up -d | |||
| docker-compose up --wait | |||
There was a problem hiding this comment.
these are still on the old docker-compose
There was a problem hiding this comment.
Should be fine, as people will probably just have one docker-compose locally, on v2.
There was a problem hiding this comment.
Actually, maybe on linux distros generally there can be both docker-compose v1 and docker compose v2? So probably good to update to docker compose everywhere.
