Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: filterText triggered selection range removal when comple… #5279

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

marinsokol5
Copy link
Contributor

…tions range was present (#5249)"

This reverts commit b586e4d.

  • We have to revert it as it caused unexpected problems during insertion of completions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (9cddf64) 87.26% compared to head (655b356) 87.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5279      +/-   ##
==========================================
- Coverage   87.26%   87.24%   -0.02%     
==========================================
  Files         567      567              
  Lines       45351    45338      -13     
  Branches     6934     6934              
==========================================
- Hits        39574    39556      -18     
- Misses       5777     5782       +5     
Flag Coverage Δ
unittests 87.24% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/autocomplete.js 81.48% <100.00%> (ø)
src/autocomplete_test.js 97.68% <100.00%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marinsokol5 marinsokol5 merged commit 78904e0 into master Aug 9, 2023
2 of 3 checks passed
@marinsokol5 marinsokol5 deleted the revert-range-bug branch August 9, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants