Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Double range removal when completion.range present #5249

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jul 10, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (c910951) 87.22% compared to head (4109e74) 87.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5249      +/-   ##
==========================================
+ Coverage   87.22%   87.24%   +0.02%     
==========================================
  Files         565      565              
  Lines       45251    45297      +46     
  Branches     6927     6928       +1     
==========================================
+ Hits        39469    39519      +50     
+ Misses       5782     5778       -4     
Flag Coverage Δ
unittests 87.24% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/autocomplete.js 81.48% <100.00%> (ø)
src/autocomplete_test.js 97.81% <100.00%> (+0.13%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oykuyilmaz oykuyilmaz merged commit b586e4d into ajaxorg:master Jul 12, 2023
3 checks passed
marinsokol5 added a commit that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants